[PATCH] Fix bug #10431 - STATUS_NO_MEMORY response from Query File Posix Lock request

Jeremy Allison jra at samba.org
Wed Feb 26 17:40:21 MST 2014


Hi Volker & Jeff,

Here's a fix for master:

brl_get_locks_readonly() currently returns NULL when it can't
find any byte range locks on the file. This is an error - it
should return a valid struct byte_range_lock containing num_locks == 0
so it can be cached.

Returning NULL when there are no locks causes POSIX lock
tests to fail returning NT_STATUS_NO_MEMORY (as it thinks
it can't allocate the struct) instead of NT_STATUS_OK.

Please review - it fixes the POSIX lock tester Jeff
is using.

Cheers,

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-Ensure-brl_get_locks_readonly-always-returns.patch
Type: text/x-diff
Size: 1862 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140226/a1567f8d/attachment.patch>


More information about the samba-technical mailing list