[PATCH] vfs: propagate snapshot enumeration permissions errors

Andrew Bartlett abartlet at samba.org
Wed Feb 26 16:33:14 MST 2014


On Thu, 2014-02-27 at 00:06 +0100, David Disseldorp wrote:
> The current FSCTL_GET_SHADOW_COPY_DATA/FSCTL_SRV_ENUMERATE_SNAPSHOTS
> handler squashes all non-ENOSYS errors into an NT_STATUS_UNSUCCESSFUL
> response.
> This commit ensures that permissions errors are propagated up to the
> client as NT_STATUS_ACCESS_DENIED, to aid debugging.
> The Windows Explorer "Previous Versions" dialogue doesn't appear to
> distinguish between error codes. It displays "There are no previous
> versions available" in both cases.

Any particular reason not to use the generic mapping from unix error
codes? 

Andrew Bartlett
-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list