[PATCH] doc: remove invalid "valid" parameter from the docs
abartlet at samba.org
Wed Feb 26 13:57:09 MST 2014
On Wed, 2014-02-26 at 11:07 +0100, Björn Jacke wrote:
> On 2014-02-24 at 11:43 +1300 Andrew Bartlett sent off:
> > Additionally, the implementation of 'available' seems very fragile.
> > Could you add a test to prove it actually works (and keeps working)?
> I'll have a look how to do that. But why you think this is parameter so
> fragile implemented?
Try and find how a 'not available' share is prevented from being
available. You will find that it is checked, but hidden behind a macro
at the same time we check for hosts allow/deny. I call it fragile
because it seems a parallel code path could easily be created during a
future re-factor, and nobody would notice this check being lost.
> As the "-valid" parameter is not used and a settable parameter, would you mind
> to review/push the patch that removes this from the docs?
That's the thing! It is used, parsed AND settable by the administrator!
We can and do agree that exposing this internal implementation detail to
our users is INSANE, but until that stops happening, the docs are
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part
More information about the samba-technical