[PATCH] Patchset for bug #10344 - SessionLogoff on a signed connection with an outstanding notify request crashes smbd.

Jeremy Allison jra at samba.org
Wed Feb 26 13:08:10 MST 2014

On Wed, Feb 26, 2014 at 10:05:46AM -0800, Jeremy Allison wrote:
> On Wed, Feb 26, 2014 at 07:01:23AM +0100, Stefan (metze) Metzmacher wrote:
> > 
> > I think we need to solve this a bit more generic,
> > a close on a file handle will also trigger this
> OK, more thoughts :-).
> Actually a close on a file handle won't trigger
> a signing crash. Currently a close doesn't cancel
> out a pending notify and we should (I'm sure Windows
> does) but all that will occur is the notify
> will notice an invalid handle once it gets
> scheduled after the close.

Shows what I know :-). Actually a close
*will* cancel out a pending notify (it's
just done inside the smbd/close.c code
not in the smb2 layer).

So close correctly handles blocking locks
pending, notifies pending, and waits for
outstanding async IO - and gets called
on tdis and logoff. So I think it's
actually OK :-).


More information about the samba-technical mailing list