[PATCH] Patchset for bug #10344 - SessionLogoff on a signed connection with an outstanding notify request crashes smbd.

Jeremy Allison jra at samba.org
Wed Feb 26 11:55:09 MST 2014


On Wed, Feb 26, 2014 at 07:44:15PM +0100, Stefan (metze) Metzmacher wrote:
> 
> If it's only the signing can't we use the
> somehow set the req->last_key or req->first_key (or similar) field
> of the pending request?
> 
> If so is it enough to do that just for session for now
> in order to fix the urgent bug?

Possibly. However I actually think my patch
makes the server *better* :-). It certainly
makes us behave like Windows when closing
out a session or connection with pending
notifies.

My current plan is to build on top of
what I've got to create a generic 'cancellation'
method to deal with resources being
destroyed when there are pending async
requests.

Volker showed the way with the
deferred close mechanism using
his tevent_wait_send() functionality,
I think this is the right idea
long term.

But I have lots of other bugs to
fix first :-).

Jeremy.


More information about the samba-technical mailing list