[PATCH] Patchset for bug #10344 - SessionLogoff on a signed connection with an outstanding notify request crashes smbd.

Jeremy Allison jra at samba.org
Wed Feb 26 10:55:24 MST 2014


On Wed, Feb 26, 2014 at 07:01:23AM +0100, Stefan (metze) Metzmacher wrote:
> 
> In smbd_server_connection_terminate() we need think about how to
> remove pending requests so that we really remove all opens, tcons and
> sessions
> in the first run.

One other point. Yeah, this is certainly a long
term issue we must fix, but it isn't actually
the problem I'm trying to solve with this specific
patch.

In the tdis, logoff case the connection continues,
as there may be other sessions outstanding on it.
Crashing in the smbd_server_connection_terminate()
isn't good, but we were terminating anyway.

The bug I'm trying to fix is one where we may
still be alive and trying to continue, not
terminating - crashing whilst trying to continue
is a more urgent problem IMHO :-).

Jeremy.


More information about the samba-technical mailing list