[PATCH] Use talloc in source3 loadparm, make more handlers common

Andreas Schneider asn at samba.org
Wed Feb 26 06:14:21 MST 2014

On Monday 24 February 2014 17:46:52 you wrote:
> Now that much of loadparm is generated and made regular, Garming's
> attention has turned to the requested task of merging common code.  In
> particular, there is a strong desire to undo the #include of
> param_table.c, and these steps are all critical to that goal.
> The patch series starts with a simple talloc -> malloc conversion, and
> later patches construct an appropriate talloc tree.  Many other small
> changes are needed or desired along the way.
> The general approach is to use the s3_fns hook to handle the special
> cases where the source3 code does something different, and to then
> slowly eliminate these hooks as even more code becomes common.
> The patch series starts here:
> https://gerrit.sernet.de/97
> https://gerrit.sernet.de/#/q/status:open+project:samba+branch:master+topic:l
> oadparm-talloc-polish,n,z

I've reviewed them in Gerrit. There are function were I think we should remove 
them completely and use talloc and talloc pools.

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list