[PATCH] doc: remove invalid "valid" parameter from the docs
abartlet at samba.org
Sun Feb 23 02:51:16 MST 2014
On Sat, 2014-02-22 at 14:07 +0100, Björn Jacke wrote:
> On 2014-02-22 at 13:34 +0100 Björn Jacke sent off:
> > we don't have such a parameter, "availbale" is the name for this, which is also documented.
> ah, I just saw this one:
> commit 8427c797cecc88d70bdee4f310351ca3d4c310db
> Author: Garming Sam <garming at catalyst.net.nz>
> Date: Wed Jan 8 14:38:09 2014 +1300
> lib/param: set default for -valid parameter
> This parameter isn't used in any of the lib/param code and is being added for consistency
> Signed-off-by: Garming Sam <garming at catalyst.net.nz>
> Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> Reviewed-by: Michael Adam <obnox at samba.org>
> can we revert this ? initializing a weird parameter which is not
> used and for which we actually have a different one anyway doesn't make much
> sense to me. Or did I oversee something, Garming, Andrew, Michael?
I would rather see it go away when we rework the source3 loadparm code
to remove the 'valid' boolean from the service structure.
None of the recent changes made this more or less an actual implemented
parameter, it is meaningless in lib/param but used in source3/param.
The documentation and implementation was already in place in that
codebase, all you see here is work to ensure the code matches the
documentation, because the docs.py test now enforces this.
I hope this clarifies things,
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical