[PATCH 0/7] Check for and propogate clitar memory allocation errors

Andrew Bartlett abartlet at samba.org
Thu Feb 20 16:14:53 MST 2014

On Thu, 2014-02-20 at 19:47 +0100, David Disseldorp wrote:
> This patch-set removes the existing PANIC_IF_NULL() memory allocation
> error handling code in clitar.c. Instead, memory allocation failures are
> propagated up to callers.
> Feedback appreciated.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

While I'm not opposed to panic after memory allocation fail (we have a
lot of code, even beside talloc_stackframe() that does this), the way
this particular code did it seemed rather ugly.

Do you want this pushed to autobuild, or were you looking for more

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list