[PATCH] Handle non-constant strings properly and share the param_globals structure

[Garming Sam]

On 21/02/14 06:17, Andreas Schneider wrote:
> In the first patch, please change NULL pointer checks like:
>
> if (!ntvfs->ctx->fs_type) {
>
> to
>
> if (ntvfs->ctx->fs_type == NULL) {
>
>
> In several locations it is already correct :)
>
> Could you please fix them?
>
>
> Instead of adding TALLOC_FREE(tmp_ctx) everywhere, I would like to have
>
> NTSTATUS myfunc()
> {
> 	NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
>
> ...
>
> 	if (something wrong) {
> 		status = NT_STATUS_NO_MEMORY;
> 		goto out;
> 	}
>
> ...
>
> 	status = NT_STATUS_OK;
> out:
> 	talloc_free(tmp_ctx);
>
> 	return status;
> }
>
> The other patches look quite good.
>
>
> Best regards,
>
>
>
>
> 	-- andreas
>

Here's the tidyups. Looks like the patches already went into master.


Cheers,

Garming Sam

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-tidy-up-some-null-checks-in-ntvfs.patch
Type: text/x-patch
Size: 1836 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140221/fcd1994a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-tidy-up-vfs-cifs-in-regards-to-using-share_string.patch
Type: text/x-patch
Size: 4401 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140221/fcd1994a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-tidy-up-vfs-smb2-in-regards-to-using-share_string.patch
Type: text/x-patch
Size: 3911 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140221/fcd1994a/attachment-0002.bin>