Removing the NT_STATUS_HAVE_NO_MEMORY_AND_FREE macro

[Kamen Mazdrashki]

Sorry for not replying for so long.

In general I am not against those patches.

My primary concern was with code readability (yes, I know this is
different for different people) :)
What confuses me with C is the lack OOM exceptions.

It would be nice if have something like:
some_type *p = talloc(cts, some_type);
OOM(p); // !p || BOOM(no memory) and free-contexts and return ENOMEM;

Cheers,
Kamen



On Tue, Feb 18, 2014 at 11:01 PM, Andrew Bartlett <abartlet at samba.org>wrote:

> On Mon, 2014-02-17 at 17:42 -0800, Jeremy Allison wrote:
> > On Mon, Feb 17, 2014 at 11:09:12AM +0100, Michael Adam wrote:
> > >
> > > ... our practice for coding rules is that we try to make
> > > *new* code adhere to them. Existing code can be adapted
> > > as it is touched. We do not usually walk over the existing
> > > code and do changes just to make it adhere to the guidelines.
> > > Doing this has several downsides:
> > >
> > > - It blurs code ownership.
> > > - It makes backports harder.
> > > - It is seductive to do tons of scripted changes
> > >   instead of concentrating on real work.
> > >
> > > So as a consequence, while I do in principle agree
> > > with the result of the patches, I am sceptical
> > > towards this change.
> >
> > If this were a larger, more invasive change set
> > I would agree. But having looked over this change:
> >
> > a). it isn't really invasive (and so won't blur
> > ownership).
> > b). IMHO the patchset is in the same vein as changes that
> > Volker, myself and others do every day to tidy
> > up the code and make it more maintainable.
> >
> > Some people just find it easier to do things by scripts
> > rather than by hand :-).
> >
> > Having said that, as it *is* merely a code cleanup I
> > can also live without it of course if people
> > disagree.
>
> I totally agree.  I think we have gone over things enough, and it would
> be great if we could get the changes pushed.
>
> Jeremy,
>
> Did I see your review on the second set of patches?
>
> Thanks,
>
> Andrew Bartlett
>
> --
> Andrew Bartlett
> http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT
> http://catalyst.net.nz/services/samba
>
>
>
>
>