[PATCH] Patch to implement AD password lockout in Samba's AD DC

Stefan (metze) Metzmacher metze at samba.org
Wed Feb 19 14:08:13 MST 2014

Hi Andrew,

>> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/s4-bwdPwdCount-01
> I've updated the branch at 
> git://git.samba.org/abartlet/samba.git s4-badPwdCount-02
> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/s4-bwdPwdCount-02
> I have also uploaded these to gerrit at
> https://gerrit.sernet.de/#/q/status:open+project:samba+branch:master
> +topic:abartlet/s4-badPwdCount-02,n,z
> With the tests now finished, these changes are now ready for master.
> I will separately co-ordinate with the Heimdal team and work out how we
> can detect the correct Heimdal version, and look at updating our
> internal Heimdal.  (The reality is that only Debian builds against a
> system Heimdal, and we already have another special patch to cope with
> using a modern heimdal). 
> Please review/push.

I'll have a look at them in detail tomorrow, but my first impression is that
you should use more helper variables, avoid deep indentation levels (try
to use early returns and avoid } else { if the if section calls return)
and avoid functions calls in the variable declaration section.

Were is the password grace period documented in the microsoft docs?


More information about the samba-technical mailing list