[PATCH] smbclient tarmode rewrite

David Disseldorp ddiss at suse.de
Tue Feb 18 04:10:28 MST 2014

Hi Andreas,

On Mon, 17 Feb 2014 13:47:15 +0100, Andreas Schneider wrote:

> the style of the code is often not easy to read especially the opposite of a 
> bool for the return code. I've added additional patches to improve readability 
> there.

Thanks for the cleanup patches. I'd hoped to keep the annotation info
with Aurélien, but am fine running with these. IIRC, the int/bool
interface is a carry-over from the previous clitar API.

> I also found is_subpath() pretty scary. I would suggest to simply use 
> strstr_m().

This may be an issue given that is_subpath() handles both Windows and
UNIX path separators. I'll check the callers and push if everything's
in order.


More information about the samba-technical mailing list