General Coverity Fixes - 3 enclosed.

Ira Cooper ira at samba.org
Mon Feb 17 05:19:29 MST 2014


On Mon, Feb 17, 2014 at 5:47 AM, Volker Lendecke
<Volker.Lendecke at sernet.de>wrote:

> On Sat, Feb 15, 2014 at 10:39:32PM -0500, Ira Cooper wrote:
> > The "s3:passdb: Fix the use of uninitialized scalar variable:"
> >
> > Needs a rework.  I'll get you a new version soon.
>
> Yep, I doubt this compiles. "search_users" returns a bool,
> whereas in many compile environments NTSTATUS is a struct. I
> wonder how you got this through your build internally. What
> kind of compiler are you using? It can't be reasonably
> modern gcc.
>

Or, I trusted a local contributor.

I won't be doing that again.

My apologies to the team,

-Ira


More information about the samba-technical mailing list