[PATCHES] a few small patches to tdb

Michael Adam obnox at samba.org
Fri Feb 14 01:57:58 MST 2014

On 2014-02-13 at 17:21 -0800, Jeremy Allison wrote:
> On Thu, Feb 13, 2014 at 05:20:39PM +0100, Michael Adam wrote:
> > Attached find a few small patches to tdb.
> > Two make the output of tdbtool dump a little more
> > consistent, and two simplify and systematize
> > tdb_delete_hash() a bit.
> > 
> > Review and push appreciated.
> Ok, in this patch :
> -------------------------------------------------
> From: Michael Adam <obnox at samba.org>
> Date: Thu, 13 Feb 2014 16:48:35 +0100
> Subject: [PATCH 3/4] tdb: simplify tdb_delete_hash() a bit
> ...
> -------------------------------------------------
> There is one more functional change you haven't
> listed here.
> That is with the change to call tdb_find_lock_hash()
> first, if the record you're trying to delete doesn't
> exist, in the dead records case the pruning of the
> dead records on the hash chain of the missing record
> doesn't get done, whereas in the existing code it
> does get done.
> Not I would doubt that's a problem, but tdb semantics
> can be tricky :-), so I wanted to make sure you were
> aware of this change.
> If you are and you're ok with it, then please expand
> the comment to include this change and I'll re-review.

Thanks for pointing this out.
This is entirely correct and I updated the
commit message to explain this change and why it
is no problem.

Attached, but while we're at it also experimentally uploaded to


or, individually:

Thanks - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/d0cd08db/attachment.pgp>

More information about the samba-technical mailing list