[PATCH] Handle non-constant strings properly and share the param_globals structure

Garming Sam garming at catalyst.net.nz
Thu Feb 13 17:26:46 MST 2014


Hi,

So the attached patches are some of the work I've been doing on loadparm.

The lib/param code has been changed to handle non-constant strings 
correctly. This involved changing the code to pass down a memory context 
in certain parts of the code.

We can now use the same globals structure across the two loadparms, 
eliminating the need to call lp_functions from the lib/param code. By 
doing this, it means that we no longer need to dynamically generate the 
s3_param.h file and loadparm_ctx_table and they have now been removed.

Also included is a couple suggested tidyups.


Please review.


Cheers,

Garming Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-pass-down-a-memory-context-when-performing-share_.patch
Type: text/x-patch
Size: 31719 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lib-param-handle-non-constant-strings-properly-by-pa.patch
Type: text/x-patch
Size: 10284 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-lib-param-rename-lp_string-to-lpcfg_string.patch
Type: text/x-patch
Size: 4297 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-param-use-loadparm_globals-struct-instead-of-lp-func.patch
Type: text/x-patch
Size: 7697 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-param-remove-generated-loadparm-ctx-table-file-and-i.patch
Type: text/x-patch
Size: 4956 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-param-change-s3_param.h-from-a-generated-file-to-a-s.patch
Type: text/x-patch
Size: 6422 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-param-remove-lp_dnsdomain-from-s3.patch
Type: text/x-patch
Size: 2571 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-param-add-const-to-a-local-variable-to-prevent-a-war.patch
Type: text/x-patch
Size: 1013 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140214/4205ce44/attachment-0007.bin>


More information about the samba-technical mailing list