[PATCH] dcerpc: witness, security verification trailer and more

Stefan (metze) Metzmacher metze at samba.org
Wed Feb 12 11:08:11 MST 2014

Am 12.02.2014 19:05, schrieb David Disseldorp:
> On Wed, 12 Feb 2014 18:58:50 +0100, Stefan (metze) Metzmacher wrote:
>> Günther found a bug in
>> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=9e7ec368537ddcc5d1806e8711f728e8cbd31f02
>> dcerpc_binding_get_string_option(b, "target_hostnam");
>> is missing an 'e'.
>> He'll fix this before pushing to master...
> s4:librpc/rpc: use dcerpc_binding_dup() before modifying the given binding
> +       if (composite_nomem(s->binding, c)) return c;
> ...please clean up this before pushing too.

??? What's wrong there?

I kept the ugly coding style as the whole file uses it,
I may rewrite all of this to use tevent_req in future, then
I'll fix the style...


More information about the samba-technical mailing list