[PATCH] Generate param_functions.c and associated files from XML documentation
obnox at samba.org
Tue Feb 11 16:50:00 MST 2014
On 2014-02-12 at 10:20 +1300, Andrew Bartlett wrote:
> This is the current patch series for the loadparm work Garming and I
> have done. I'm sorry to have to note that it has now been 4 weeks since
> this was first posted on 14 Jan.
Yeah, sorry, but big patchsets take time, and
there are subtleties hidden here that did not advise
rushing this in...
I have reviewed the patches and added reviewed-by-/me tags to
most of them in my master-param branch.
There are two questions/remarks:
1) I think we need to special case 0 for smb2 max credits
as a protection: if we leave the value at 0,
we do "... % 0" in the code using this...
So the patch as such is not acceptable.
2) could we split the patch
"lib/param: Deprecate and normalise "read raw" and "write raw"
we should not do normalization and deprecation in one patch,
Also: why do you deprecate them at all?
If you remove the deprecation (doc change)
and only do the normalization for a start,
you have my reviewed-by for it.
So skipping the max credits patch for a start
and skipping the deprecation for the read/write raw
patch, feel free to push w/ my review.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 215 bytes
Desc: Digital signature
More information about the samba-technical