[PATCH] RFC debug detect winbindd version mismatches

Andrew Bartlett abartlet at samba.org
Tue Feb 11 14:58:28 MST 2014


Thanks for getting back to us, and I do apologise for the delay in
reviewing this.

On Thu, 2014-01-30 at 09:36 +0000, Noel Power wrote:

>      if ((winbind_open_and_version_check_socket(&request, &response) !
> = NSS_STATUS_SUCCESS) || (response.data.interface_version !=
> WINBIND_INTERFACE_VERSION)) {
>                 return -1;
>         }

Why do you need to check the interface_version here again?  By my
reading winbind_open_and_version_check_socket should have already done
that.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list