[PATCHv2] build: allow some python variable overrides
abartlet at samba.org
Fri Feb 7 11:03:55 MST 2014
On Wed, 2014-02-05 at 00:15 +0100, David Disseldorp wrote:
> Thanks for your cross-compilation efforts Gustavo!
> On Tue, 4 Feb 2014 14:23:41 -0300
> Gustavo Zacarias <gustavo at zacarias.com.ar> wrote:
> > The python variables (settings) are fetched from a running python
> > interpreter which usually isn't the target one when cross compiling,
> > hence libraries and flags aren't the same and can pollute the target
> > build.
> > Allow some of these variables to be redefined via environment variables
> > in order to aid cross-compiling.
> > According to testing python_LDFLAGS and python_LIBDIR should be enough.
> > Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> Reviewed-by: David Disseldorp <ddiss at samba.org>
> In need of one more review + push.
I'm not entirely comfortable with this as a solution, as it isn't
'discoverable'. That is, how will the next user attempting
cross-compile of Samba find it?
I realise this is one of the most difficult challenges in this
cross-compilation saga, and if this was a patch to just the wafsamba end
of things, I might be willing to say OK, but I don't see how this would
be acceptable upstream (meaning we have to rework it at some point
anyway) and it just doesn't feel right, I have to ask that we try
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical