[PATCH] build: don't execute statfs and f_fsid checks
gustavo at zacarias.com.ar
Fri Feb 7 10:59:11 MST 2014
On 02/07/2014 02:51 PM, Andrew Bartlett wrote:
> The difficulty here is to understand why this code was executed in the
> first place. It was executed in the autoconf build, and an extensive
> look into that codebase hasn't made it possible to find the rationale
> there either.
> The other frustration is that this check is in a different spot to the
> other statfs checks (under lib/util), some of which do seem to genuinely
> need to be run. (It seems to duplicate part of those other tests).
> In any case, what do you mean when you say it's undefined on some
By looking at the statfs manpage (in linux):
Nobody knows what f_fsid is supposed to contain (but see below).
And then there's a whole explanation on what the different *xes do with it.
For samba 3.6.x at least the test passes thru without explicitly needing
to execute it, didn't look into 4.0.x but IIRC it was the same case,
snip from a 3.6.x config.log:
configure:37221: checking vfs_fileid: checking for statfs() and struct
configure:37254: result: cross
So it'll basically assume a default on it if it can't test it.
The same does not happen on 4.1.x, in fact i can't even cache the answer
for some odd reason and thus is a stumbling block for cross compiling.
More information about the samba-technical