[PATCHSET] dbwrap, read only copies, lock order

[Stefan (metze) Metzmacher]

Am 07.02.2014 12:31, schrieb Amitay Isaacs:
> On Fri, Feb 7, 2014 at 7:28 PM, Stefan (metze) Metzmacher
> <metze at samba.org>wrote:
> 
>> Hi Amitay,
>>
>>>>
>>> Hi Michael,
>>>
>>> Patches looks good.
>>>
>>> Only question is:  Since the flag DBWRAP_FLAG_OPTIMIZE_READONLY_ACCESS is
>>> meant to optimize the access, do we need fail db_open_ctdb if
>>> SET_DB_READONLY control fails?  Database is attached successfully at this
>>> stage and it will still work.
>>
>> In what situations would this be able to fail if the ctdb headers indicate
>> it's supported?
>>
>>
> If CTDB is not able to set up tracking database, the control can fail. I
> usually won't expect
> the control to fail, but it's possible.

Shouldn't we consider the node unhealthy in such a situation?

metze