[PATCH] NetShareSetInfo - letting CSC policy be settable

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Feb 5 04:19:06 MST 2014

On Tue, Feb 04, 2014 at 04:04:19PM +0530, Shekhar Amlekar wrote:
> Hi,
> Please find following patches in the NetShareSetInfo code for review -
> 0001 - fix a bug wherein incorrect value of max_connections was passed to 
> 'change share command' for info levels !=2
> 0002 - let CSC policy be settable from client and send it as a parameter 
> to the 'change share command'
> 0003 - man page changes for 0002
> Would you please review and let me know your comments if any.

Thanks, they look good.

Can you augment the documentation with the values that can
happen in the sixth parameter? Or give a hint that the user
can find the values in the "csc policy" section?

We also need to make sure that this changed parameter is
mentioned in the release notes for 4.2.

With best regards,

Volker Lendecke

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list