[PATCH] Fix failures on re-provision incorrectly blamed on posix acl support.

[Garming Sam]

On 05/02/14 12:19, Jelmer Vernooij wrote:
> On Wed, Feb 05, 2014 at 11:45:24AM +1300, Andrew Bartlett wrote:
>> On Tue, 2014-02-04 at 15:42 -0700, BlackPenguin ADMIN wrote:
>>> That works. I just tried it. Thank you!
>> Great.
>>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>
>> Jelmer,
>>
>> Can I get your review on this?
> I realize you're just moving code, but this code could use some more
> improvements. It's catching all Exceptions, making assumptions about the kind
> of error that is occurring. Most of the lines are also too long.
>
> Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
>
> Cheers,
>
> Jelmer
>
Hi Jelmer,

So we've put in an OSError in pysmbd so that we can catch this less 
broadly.

With the new order of things, a call to samdb.connect is now the first 
thing to fail when attempting a provision with incorrect permissions. 
But the failure messages weren't particularly helpful, so we've tried to 
change them in these patches. We now pass up a permission denied error.

Any other suggestions while we're looking at this stuff?


Cheers,

Garming Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-provision-Fix-failures-on-re-provision-incorrectly-b.patch
Type: text/x-patch
Size: 4023 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140205/d75a139b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ldb-Return-LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS-rather.patch
Type: text/x-patch
Size: 1296 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140205/d75a139b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dsdb-Return-LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS-rathe.patch
Type: text/x-patch
Size: 1603 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140205/d75a139b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-ldb-pass-module-init-errors-back-to-the-caller.patch
Type: text/x-patch
Size: 1112 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140205/d75a139b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-provision-improve-error-message-when-connecting-to-s.patch
Type: text/x-patch
Size: 1315 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140205/d75a139b/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-pysmbd-improve-the-return-of-error-codes-in-the-pyth.patch
Type: text/x-patch
Size: 5622 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140205/d75a139b/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-provision-capture-slightly-less-generic-exceptions-d.patch
Type: text/x-patch
Size: 1570 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140205/d75a139b/attachment-0006.bin>