[PATCH] Change smb.conf.5 build to use XML entities to get always-correct default paths
abartlet at samba.org
Sat Feb 1 03:26:15 MST 2014
On Thu, 2014-01-30 at 21:53 +1300, Andrew Bartlett wrote:
> On Thu, 2014-01-30 at 06:54 +0100, Christian PERRIER wrote:
> > Quoting Andrew Bartlett (abartlet at samba.org):
> > > This patch set, inspired by the desire to check all parameter defaults
> > > in an improved docs.py test, makes the defaults in our 'man smb.conf'
> > > always correct for paths.
> > >
> > > Because the defaults for some parameters depend on configure options,
> > > this provides these options to the XML generation by the means of XML
> > > entities - the CPP macros of the XML world.
> > >
> > > Because XInclude only works for full, compliant XML documents, we also
> > > have to change the code to manually concatenate the per-parameter XML
> > > documents into one big parameters.all.xml.
> > >
> > > This means that no matter what --prefix you put to configure, the
> > > smb.conf manpage will list the correct defaults for your platform. This
> > > will also avoid distributions needing to patch the docs to correct the
> > > paths.
> > That would be a great great improvement because of that last
> > consequence, definitely. Thanks a lot, Andrew, for this proposal.
> I couldn't find a patch to do that in the current packaging (perhaps
> lost with the 4.0 package), but indeed, I was thinking of Debian in
> particular when I decided this was worth the effort.
Now the patches are in master, perhaps you would like to backport them
to the 4.0 and 4.1 debian packages? It would probably 'just work', this
stuff hasn't changed a lot in recent times.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical