[PATCH] Statlite - without VFS changes

Shekhar Amlekar samlekar at in.ibm.com
Wed Dec 24 02:43:51 MST 2014

Hi Ralph,

The initial patch I floated proposed an interface similar
to what you mention -


However, it required changes to many VFS modules,
As you know, there are modules that change path
(catia, cap, mh, scannedonly), some that change the
stat struct (fake_perms, fake_acls, fruit), and some just
audit vfs calls (full audit, time audit). Also, the opaque
modules (ceph, glusterfs) needed to handle the new
VFS call.

Overall, it became a pretty large patch - so, this is an
alternative we are exploring.


Ralph Böhme <rb at sernet.de> wrote on 12/24/2014 02:16:25 PM:

> From: Ralph Böhme <rb at sernet.de>
> To: Shekhar Amlekar/India/IBM at IBMIN
> Cc: Jeremy Allison <jra at samba.org>, samba-technical <samba-
> technical at lists.samba.org>
> Date: 12/24/2014 02:26 PM
> Subject: Re: [PATCH] Statlite - without VFS changes
> Hi Shekhar,
> On Mon, Dec 22, 2014 at 03:11:31PM +0530, Shekhar Amlekar wrote:
> > I just updated the patch with a small fix. Request you to take a look 
> > this one.
> pardon my ignorance, I'm by no means an expert in the Samba VFS design
> intricacies and so I'm probably just failing to see the reason why
> you're overloading the stat VFS interface.
> Is this just for the purpose of avoiding a VFS interface change? I
> guess sometime you just have to bite the bullit.
> My understanding of your code is that existing SMB_VFS_STAT calls
> semantics are completey unchanged because the request mask is
> initialized by STATLITE_SET_EXACT and the statlite semantics are only
> used in the wrapper functions vfs_path_get_partial_stat() and
> vfs_path_exists() ?
> It seems the code could do without any subtle munging of the stat VFS
> calls by simply adding new full fledged VFS call
> SMB_VFS_[F|L]STATLITE() and using that in the wrappers
> vfs_path_get_partial_stat() and vfs_path_exists().
> Cheerio!
> -Ralph
> -- 
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de,mailto:kontakt@sernet.de

More information about the samba-technical mailing list