[PATCH] Statlite - without VFS changes

Ralph Böhme rb at sernet.de
Wed Dec 24 01:46:25 MST 2014

Hi Shekhar,

On Mon, Dec 22, 2014 at 03:11:31PM +0530, Shekhar Amlekar wrote:
> I just updated the patch with a small fix. Request you to take a look at 
> this one.

pardon my ignorance, I'm by no means an expert in the Samba VFS design
intricacies and so I'm probably just failing to see the reason why
you're overloading the stat VFS interface.

Is this just for the purpose of avoiding a VFS interface change? I
guess sometime you just have to bite the bullit.

My understanding of your code is that existing SMB_VFS_STAT calls
semantics are completey unchanged because the request mask is
initialized by STATLITE_SET_EXACT and the statlite semantics are only
used in the wrapper functions vfs_path_get_partial_stat() and
vfs_path_exists() ?

It seems the code could do without any subtle munging of the stat VFS
calls by simply adding new full fledged VFS call
SMB_VFS_[F|L]STATLITE() and using that in the wrappers
vfs_path_get_partial_stat() and vfs_path_exists().


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list