waf vs enrionment CPPFLAGS and LDFLAGS

Ralph Böhme rb at sernet.de
Fri Dec 19 14:36:47 MST 2014


On Tue, Oct 28, 2014 at 10:55:04AM -0700, Jeremy Allison wrote:
> On Tue, Oct 28, 2014 at 06:24:02PM +0100, Ralph Böhme wrote:
> > > > > was a request to file a bugreport. I'll do that now.
> > > > 
> > > > <https://code.google.com/p/waf/issues/detail?id=1505>
> > > 
> > > Great - thanks. Can you re-submit your waf fix for
> > > the Samba tree and I'll review asap.
> > 
> > It's a hack, not a fix! ;) From the commit message:
> > 
> >     Just a hack to show what's needed, the proper fix would habe to
> >     somehow fixup the template strings in wafsamba/.
> 
> Can you post the correct fix for waf rather than
> a "hack" fix ?

metze, here's the (hopefully) final version of the fix which works for
both CPPFLAGS and LDFLAGS:

<https://git.samba.org/?p=slow/samba.git;a=commitdiff;h=60200fb91117127150e9b8fe5f08481386354786>

Thanks for your help, I'm feeling like a real waf hacker now! ;)

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de


More information about the samba-technical mailing list