[PATCH] New VFS Module "unityed_media" for sharing AVID projects

Ralph Böhme rb at sernet.de
Fri Dec 19 14:01:42 MST 2014


Hi Jeremy,

On Tue, Dec 16, 2014 at 03:20:07PM -0800, Jeremy Allison wrote:
> On Mon, Dec 08, 2014 at 06:55:35PM +0100, Ralph Böhme wrote:
> > Hi all,
> > 
> > attached is a new VFS module for improved AVID project sharing, from
> > the commit message:
> > It's been tested by 3rd party and reported to work flawlessly. Please
> > review, comment and/or push if ok.
> 
> First comment/fix needed.
> 
> get_digit_group() walks through a pathname using:
> 
> +       while (*p) {
> +               if (isdigit(*p)) {
> +                       *digit = (uintmax_t)strtoul(p, &endp, 10);
> +                       DEBUG(10, ("num_suffix = '%ju'\n",
> +                                             *digit));
> +                       return true;
> +               }
> +               p++;
> +       }
> 
> This won't work for non-ASCII files. Use next_codepoint()
> to walk through pathname strings.

thanks, will fix and resubmit.

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de


More information about the samba-technical mailing list