[PATCHEs] wafsamba: fix ordering problems with lib-provided and internal RPATHs

Stefan (metze) Metzmacher metze at samba.org
Thu Dec 18 14:49:59 MST 2014

Am 18.12.2014 um 22:45 schrieb Michael Adam:
> On 2014-12-18 at 22:16 +0100, Stefan (metze) Metzmacher wrote:
>> Am 18.12.2014 um 22:13 schrieb Michael Adam:
>>> this is nice, but the patch you want to revert from wafadmin is
>>> upstream, so it would be wrong to revert it. It was also fixed
>>> in newer waf versions. I'd also argue that your fix is not
>>> necessarily a better fix, since the bug in question is a proper
>>> bug in wafadmin. But it is nice that you found a way to do it in
>>> wafsamba that is not too complicated! We can add that
>>> additionally if you want.
>>> And I can see whether I can use the ideas for modifying our
>>> "wellknown libpaths" to not touch wafadmin.
>> Ah, ok then we just should not push the revert patch, but keep
>> the otherone to handle '-Wl,-R,' too.
> I don't quite understand: Your patch to samba treats nothing
> the original wafadmin patch does not catch. It even uses the
> same checks. :-)

I only handles -Wl,-R but not -Wl,-R,

>> The wellknown libpath patch is attached:-)
> Hey, you've been quicker than me, as usual.. ;)
> I see that the actual code that retrieves the
> standard libpaths is the same as the one I sent a
> few weeks ago and that we had worked on together.
> You have only found a better place to make use of it. :-)

I start to understand the waf magic:-)


More information about the samba-technical mailing list