change idmap in the same way as passdb

Stefan (metze) Metzmacher metze at samba.org
Thu Dec 18 12:32:59 MST 2014


Here's one additional fix for
https://bugzilla.samba.org/show_bug.cgi?id=10112
from Ralph and me...

metze

Am 18.12.2014 um 20:27 schrieb Stefan (metze) Metzmacher:
> Am 18.12.2014 um 10:38 schrieb Andrew Bartlett:
>> On Thu, 2014-12-18 at 21:23 +1300, Andrew Bartlett wrote:
>>> On Thu, 2014-12-18 at 09:13 +0100, Stefan (metze) Metzmacher wrote:
>>>> Am 18.12.2014 um 08:52 schrieb Andrew Bartlett:
>>>>> Metze,
>>>>>
>>>>> Now we have successfully changed the pdb library, I propose we do the
>>>>> same with idmap.  On a solaris-like system a while back, I found our
>>>>> internal and private idmap clashing with the system idmap (for NFSv4).
>>>>> The same grouping library trick should be enough to avoid this issue as
>>>>> well.  I'll try and prepare a patch tomorrow if I'm not totally swamped
>>>>> in the rush before Christmas.
>>>>
>>>> Ok, do we already have a bug report for this?
>>>>
>>>> metze
>>>
>>> This looks like it:
>>>
>>> https://bugzilla.samba.org/show_bug.cgi?id=10112
>>
>> Metze,
>>
>> You suggested on private IRC that we find a generic solution in the
>> PRIVATE_NAME wafsamba function.  I attach my attempt at that. 
>>
>> Sadly at least on my test here, it didn't help.  Let me know if you
>> figure it out, otherwise we may have to ad-hock idmap at least for now. 
> 
> This patch seems to work.
> 
> metze
> 
-------------- next part --------------
From 07fb4545c1c5ceb39785676de283cf0c62fcfe4b Mon Sep 17 00:00:00 2001
From: Ralph Boehme <slow at samba.org>
Date: Thu, 18 Dec 2014 06:37:28 +0100
Subject: [PATCH] wafsamba: check for rpath compiler/linker flags

Older SunOS linker only support -Wl,-R,/path instead of -Wl,-rpath,/path.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10112

Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>

Signed-off-by: Ralph Boehme <slow at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
---
 buildtools/wafsamba/wscript | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript
index 1a2cfe6..1a30d2f 100755
--- a/buildtools/wafsamba/wscript
+++ b/buildtools/wafsamba/wscript
@@ -295,6 +295,10 @@ def configure(conf):
                     headers='stdio.h',
                     msg='Checking simple C program')
 
+    # check which compiler/linker flags are needed for rpath support
+    if not conf.CHECK_LDFLAGS(['-Wl,-rpath,.']) and conf.CHECK_LDFLAGS(['-Wl,-R,.']):
+        conf.env['RPATH_ST'] = '-Wl,-R,%s'
+
     # check for rpath
     if conf.CHECK_LIBRARY_SUPPORT(rpath=True):
         support_rpath = True
-- 
1.9.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141218/f13d8fa1/attachment.pgp>


More information about the samba-technical mailing list