[PATCHES] Convert gencache to dbwrap to enable mutexes

Christof Schmitt cs at samba.org
Thu Dec 18 11:54:09 MST 2014


On Thu, Dec 18, 2014 at 09:15:27AM +0100, Stefan (metze) Metzmacher wrote:
> Hi,
> 
> >>>> After that, we can either
> >>>> convert gencache_notrans to dbwrap, or add mutex support to tdb_wrap and
> >>>> convert gencache_notrans to tdb_wrap as suggested by Volker in
> >>>> https://lists.samba.org/archive/samba-technical/2014-September/102699.html
> >>
> >> The patches look good to me. I attached them with my reviewed-by, and
> >> also added patches to convert gencache to tdb_wrap, add a mutex check in
> >> tdb_wrap_open and finally request mutexes for gencache_notrans.
> > 
> > Just noticed that Volker already pushed the tdb_wrap check for mutexes.
> > Here are the remaining six patches that apply on top of the current
> > master branch. Someone would need to review the gencache changes i made.
> 
> I'm now seeing this in the in an autobuild:
> 
> memdisk/metze/a/b17912/samba/bin/smbd:
> tdb(/memdisk/metze/a/b17912/samba/bin/ab/plugin_s4_dc/cachedir/gencache.tdb):
> tdb_transaction_start: cannot start a trans
> action with locks held
> /memdisk/metze/a/b17912/samba/bin/smbd:
> tdb(/memdisk/metze/a/b17912/samba/bin/ab/plugin_s4_dc/cachedir/gencache.tdb):
> tdb_transaction_start: cannot start a trans
> action with locks held
> /memdisk/metze/a/b17912/samba/bin/smbd:
> tdb(/memdisk/metze/a/b17912/samba/bin/ab/plugin_s4_dc/cachedir/gencache.tdb):
> tdb_transaction_start: cannot start a trans
> action with locks held

Is this triggered by a specific testcase? The patches discussed here
changed gencache_notrans.tdb to not use transactions and use mutexes.
The problem in autobuild seems to be that there is already a lock or
transaction pending on gencache.tdb, and i don't see yet where that
would be coming from.

Christof


More information about the samba-technical mailing list