Why our autobuilds fail (was: Re: Make sure --with-profiling-data keeps compiling)

Jeremy Allison jra at samba.org
Tue Dec 16 09:39:05 MST 2014


On Tue, Dec 16, 2014 at 08:56:49AM +0100, Volker Lendecke wrote:
> On Tue, Dec 16, 2014 at 05:29:05PM +1300, Andrew Bartlett wrote:
> > On Mon, 2014-12-15 at 12:48 +0100, Michael Adam wrote:
> > > Reviewed-by: /me
> > > 
> > > On 2014-12-15 at 10:40 +0100, Stefan (metze) Metzmacher wrote:
> > > > Hi,
> > > > 
> > > > here's a patch that makes sure that --with-profiling-data keeps compiling.
> > > > 
> > > > metze
> > > > 
> > 
> > Sadly, I think we need to revert this.
> > 
> > The issue is, as I read the code and the failed autobuilds, is that the
> > first user (your good self) to run this on sn-devel created a shared
> > memory segment with a fixed key.  See
> > source3/profile/profile.c:profile_setup().
> >
> > All other builds attempt to create the same shared memory segment, and
> > refuse to, because they don't own it.  This then causes all autobuilds
> > to fail. 

Oh my goodness, we still use SYSV shared memory somewhere ? !!!!

Thought we'd removed that many years ago :-).

> Metze, can we get
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=25ee2483ce3d887d53f72086
> on the car pool lane? :-)

+1 from me - let's consign SYSV shmem to the dustbin
of Samba history please !

Jeremy.


More information about the samba-technical mailing list