use --picky-developer for samba-ctdb autobuild target

Amitay Isaacs amitay at gmail.com
Mon Dec 15 06:25:08 MST 2014


On Mon, Dec 15, 2014 at 9:13 PM, Amitay Isaacs <amitay at gmail.com> wrote:

> On Mon, Dec 15, 2014 at 8:28 PM, Stefan (metze) Metzmacher <
> metze at samba.org> wrote:
>
>> Hi,
>>
>> here're 2 patches to enable --picky-developer for the samba-ctdb
>> autobuild target.
>> This makes sure we don't introduce new compiler warnings into the
>> --with-cluster-support
>> related code.
>>
>> metze
>>
>
> Pushed to autobuild.
>
> Amitay.
>

Hi Metze,

Looks like gcc 4.4.3 does not like this code:

        dbgtext(fmt, ap);

I don't get any errors with gcc 4.8.3 on fedora.

[2855/4262] Compiling ctdb/server/ctdb_logging.c
cc1: warnings being treated as errors
../ctdb/server/ctdb_logging.c: In function 'ctdb_tevent_logging':
../ctdb/server/ctdb_logging.c:333: error: format not a string literal,
argument types not checked
Waf: Leaving directory `/memdisk/amitay/a/b23502/samba-ctdb/bin'
Build failed:  -> task failed (err #1):
	{task: cc ctdb_logging.c -> ctdb_logging_8.o}
make: *** [all] Error 1

Amitay.


More information about the samba-technical mailing list