use --picky-developer for samba-ctdb autobuild target

[Stefan (metze) Metzmacher]

Hi,

here're 2 patches to enable --picky-developer for the samba-ctdb
autobuild target.
This makes sure we don't introduce new compiler warnings into the
--with-cluster-support
related code.

metze
-------------- next part --------------
From 1c5f4a87db37d0f955cd76186487e17c6462f6e3 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze at samba.org>
Date: Wed, 10 Dec 2014 23:00:43 +0100
Subject: [PATCH 1/2] s3:lib: fix allocation check in messages_ctdbd.c

Signed-off-by: Stefan Metzmacher <metze at samba.org>
---
 source3/lib/messages_ctdbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/lib/messages_ctdbd.c b/source3/lib/messages_ctdbd.c
index 53aeb1f..dbca103 100644
--- a/source3/lib/messages_ctdbd.c
+++ b/source3/lib/messages_ctdbd.c
@@ -113,7 +113,7 @@ static int messaging_ctdb_send(struct server_id src,
 	}
 
 	buf = talloc_array(talloc_tos(), uint8_t, buflen);
-	if (buflen == NULL) {
+	if (buf == NULL) {
 		return ENOMEM;
 	}
 	iov_buf(iov, iovlen, buf, buflen);
-- 
1.9.1


From 279f5a74b06ccbe4ed85cb8ce9d6f8f1ecdc98e1 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze at samba.org>
Date: Mon, 8 Dec 2014 10:30:56 +0100
Subject: [PATCH 2/2] script/autobuild.py: use --picky-developer for the
 samba-ctdb target

Signed-off-by: Stefan Metzmacher <metze at samba.org>
---
 script/autobuild.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/script/autobuild.py b/script/autobuild.py
index ba08e52..e776df8 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -60,7 +60,7 @@ tasks = {
 
 
                      # build samba with cluster support against this ctdb:
-                     ("samba-configure", "PYTHONPATH=${PYTHON_PREFIX}/site-packages:$PYTHONPATH PKG_CONFIG_PATH=${PREFIX_DIR}/lib/pkgconfig:${PKG_CONFIG_PATH} ./configure.developer ${PREFIX} --with-selftest-prefix=./bin/ab --with-cluster-support --bundled-libraries=!tdb", "text/plain"),
+                     ("samba-configure", "PYTHONPATH=${PYTHON_PREFIX}/site-packages:$PYTHONPATH PKG_CONFIG_PATH=${PREFIX_DIR}/lib/pkgconfig:${PKG_CONFIG_PATH} ./configure.developer --picky-developer ${PREFIX} --with-selftest-prefix=./bin/ab --with-cluster-support --bundled-libraries=!tdb", "text/plain"),
                      ("samba-make", "make", "text/plain"),
                      ("samba-check", "./bin/smbd -b | grep CLUSTER_SUPPORT", "text/plain"),
                      ("samba-install", "make install", "text/plain"),
-- 
1.9.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141215/178e6e67/attachment.pgp>