Your Tombstone Reanimation branch
abartlet at samba.org
Sun Dec 14 21:46:08 MST 2014
Garming and I did some work to review your tombstone-reanimation-wip
brnach. I've pushed it back to
https://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/tombstone-reanimation-wip with some TODO markers (metze style).
I'm not totally convinced by the implementation of your
environment-based argument passing to the scripts. I need to be
convinced that this remains as easy to debug in make test/make testenv
as the old pattern.
I also had to fix a dupliate OID allocation, that would have conflicted
with the one we allocated for the SeMachineAccountPrivilege work, and
wasn't allocated in the schema_samba4.ldif file (which is clearly the
worse place ever for our OID registry).
We need to go over it again, and to run the tests, but it is an
impressive lump of work and I look forward to seeing it landed!
We have also some some reformatting.
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical