[PATCH] Re: wrong timestamp in log files
martin at meltin.net
Thu Dec 11 21:24:10 MST 2014
On Fri, 12 Dec 2014 11:41:40 +1100, Martin Schwenke <martin at meltin.net>
> On Thu, 11 Dec 2014 17:48:36 +0000, Youzhong Yang
> <Youzhong.Yang at mathworks.com> wrote:
> > I saw the timestamp in log files having the wrong month. Looking at the commit, shouldn't the tm->tm_mon be tm->tm_mon + 1?
> > Thanks,
> > -Youzhong Yang
> > ========================================================================
> > commit 1c2ae58509a19fb4590f4c71277c0f0c0a27f2fd
> > Author: Martin Schwenke <martin at meltin.net>
> > Date: Wed Oct 8 15:52:37 2014 +1100
> > lib/util: Use snprintf() instead of strftime() in timeval_str_buf()
> Thanks, Youzhong! I fixed this once during development but must have
> missed it when the code was refactored into timeval_str_buf().
> Patch attached. Can someone please review and push? We need this in
The logging changes aren't in 4.2, so it isn't needed.
Sorry, I'm having a bad day... :-(
peace & happiness,
More information about the samba-technical