SHARED MODULES BROKEN pdb: Increase version number to fix ABI

Andreas Schneider asn at samba.org
Thu Dec 11 06:35:57 MST 2014


On Thursday 11 December 2014 13:18:43 Alexander Bokovoy wrote:
> On Thu, Dec 11, 2014 at 10:46 AM, Andrew Bartlett <abartlet at samba.org> 
wrote:
> > On Fri, 2014-12-05 at 22:43 +1300, Andrew Bartlett wrote:
> >> On Thu, 2014-12-04 at 09:56 +0100, Andreas Schneider wrote:
> >> > On Thursday 04 December 2014 11:08:06 Garming Sam wrote:
> >> > > Hi Andreas,
> >> > 
> >> > Hi Garming,
> >> > 
> >> > > Does the attached patch fix the issues you have?
> >> > > 
> >> > > So far, I've mostly just tested what was mentioned below but I
> >> > > thought I
> >> > > should get back to you.
> >> > 
> >> > yes, this fixes the issue but I don't think this is the right way to do
> >> > it!
> >> 
> >> Can you explain why you don't think it is the right way?
> >> 
> >> This approach allows the subsystem to remain named pdb (otherwise all
> >> the init functions have to update, the on-disk directories have to
> >> update etc), while the subsystem becomes part of the on-disk library
> >> samba-passdb.
> >> 
> >> Indeed, had we done this the first time, we wouldn't have needed to
> >> update the other dependencies, which was an oversight.
> >> 
> >> > Alexander spent quite some time fixing the pdb mess so we are able to
> >> > build an external pdb module which is needed for FreeIPA. I think this
> >> > will break it again!
> >> > 
> >> > 
> >> > So this is a NAK on the patch until Alexander says otherwise :)
> >> 
> >> Can you please test if this is or is not the case, rather than
> >> hand-waving?
> > 
> > Ping?
> > 
> > Can you please clearly state what still fails after this patch is
> > applied, as this objection is blocking the 4.2 release via #10355 and
> > #10720.
> 
> NACK to Garming's patch. The problem with it is that it doesn't solve
> the problem, it only makes it worse.

RB+ for Alexander his patch.

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list