Latest leases patchset - getting there !
jra at samba.org
Mon Dec 8 13:06:38 MST 2014
On Mon, Dec 08, 2014 at 04:41:01PM +0100, Stefan (metze) Metzmacher wrote:
> > I couldn't figure out how to split out all the
> > changes and still keep everything compiling inbetween,
> > so this isn't elegantly bisectable :-(. If you
> > can figure out how to do that without it being
> > a blob of a patch, then I'll learn something :-).
> The end result is the same, but each commit passes
> TDB_NO_FSYNC=1 buildnice make -j test TESTS=smb2.*lease
> SOCKET_WRAPPER_KEEP_PCAP=1 FAIL_IMMEDIATELY=1 SMBD_DONT_LOG_STDOUT=1
> The last patch is not as small as possible, but I think it's ok.
> Please have a look and push if you also happy.
Thanks Metze, I did indeed learn something
about splitting things up :-).
At first glance looks good (I'm on a plane
at the moment enjoying the delights of in-flight
wi-fi :-) - I'll look over more carefully and
push if I'm happy !
More information about the samba-technical