[PATCH] Fix bug 10982 - fallocate() returned values on failure

Jeremy Allison jra at samba.org
Sun Dec 7 16:18:17 MST 2014


On Sun, Dec 07, 2014 at 03:15:05PM -0800, Jeremy Allison wrote:
> On Sun, Dec 07, 2014 at 08:33:46PM +0100, David Disseldorp wrote:
> > On Fri, 5 Dec 2014 15:43:15 -0800
> > Jeremy Allison <jra at samba.org> wrote:
> > 
> > > Here is the patchset for master confirmed as
> > > working by Jones <jones.kstw at gmail.com> for
> > > bug #10982 - fallocate() returned values on failure.
> > > 
> > > Please review and push !
> > 
> > A couple of minor comments:
> > - sys_posix_fallocate() may still return an errno value
> 
> Yes, that's deliberate.
> 
> Because posix_fallocate() by definition returns either
> zero or errno, I want our wrapper to do the same.
> 
> The conversion to -1,errno is done in the caller
> of sys_posix_fallocate(), so 

Sorry, hit 'send' too soon...

Should be:

The conversion to -1,errno is done in the caller
of sys_posix_fallocate(), so I'd rather keep
sys_posix_fallocate() with the errno return
convention and fix as it goes up into the VFS
layer.


More information about the samba-technical mailing list