[PATCH] Fix bug 10982 - fallocate() returned values on failure
jra at samba.org
Sun Dec 7 16:15:05 MST 2014
On Sun, Dec 07, 2014 at 08:33:46PM +0100, David Disseldorp wrote:
> On Fri, 5 Dec 2014 15:43:15 -0800
> Jeremy Allison <jra at samba.org> wrote:
> > Here is the patchset for master confirmed as
> > working by Jones <jones.kstw at gmail.com> for
> > bug #10982 - fallocate() returned values on failure.
> > Please review and push !
> A couple of minor comments:
> - sys_posix_fallocate() may still return an errno value
Yes, that's deliberate.
Because posix_fallocate() by definition returns either
zero or errno, I want our wrapper to do the same.
The conversion to -1,errno is done in the caller
of sys_posix_fallocate(), so
> - smb_time_audit_fallocate() should save errno before calling
Got it - thanks !
> Otherwise looks good.
Is that a 'Reviewed-by:' ? I'm assuming yes :-).
More information about the samba-technical