Latest leases patchset - getting there !

[Jeremy Allison]

On Fri, Dec 05, 2014 at 02:54:39PM +0100, Stefan (metze) Metzmacher wrote:
> 
> I think we need to change the data model for the
> leases_db.
> 
> Maybe something like this:
> 
> diff --git a/source3/librpc/idl/leases_db.idl
> b/source3/librpc/idl/leases_db.idl
> index 2ab1591..f6a979d 100644
> --- a/source3/librpc/idl/leases_db.idl
> +++ b/source3/librpc/idl/leases_db.idl
> @@ -15,9 +15,14 @@ interface leases_db
>         } leases_db_key;
> 
>         typedef [public] struct {
> -               uint32 num_file_ids;
> -               [size_is(num_file_ids)] file_id ids[];
> -               [string,charset(UTF8)] char *filename;
> +               file_id id;
> +               [string,charset(UTF8)] char *servicepath;
> +               [string,charset(UTF8)] char *base_name;
>                 [string,charset(UTF8)] char *stream_name;
> +       } leases_db_file;
> +
> +       typedef [public] struct {
> +               uint32 num_files;
> +               [size_is(num_filess)] leases_db_file files[];
>         } leases_db_value;
>  }
> 
> I'm not sure about the servicepath, I took the same values
> as we have in share_mode_data. But we need to maintain the names
> per file_id in order to support dynamic shares.
> 
> That way we can check if an open with the same file_id uses
> the correct file name.
> 
> BTW: How did you test the dynamic share stuff from a windows client?
> Do you have a Win32 programm we can add to testprogs/win32/ ?
> If so we could add some rename code to it.

I didn't test rename on the dynamic share stuff, sorry.

I think I see the issue. Let me think about this a
little and see if I can get it coded up (the server
fix I mean).