TEST: samba4.blackbox.dbcheck.release-4-0-0 fails

[Andrew Bartlett]

On Fri, 2014-12-05 at 17:05 +0100, Andreas Schneider wrote:
> On Thursday 04 December 2014 09:19:08 Andrew Bartlett wrote:
> > Is very interesting, as indeed we recently changed the default domain
> > functional level to 2008R2 in b9701a0a79dd15dd6f53075638fba9a2a3d92e19,
> > and patched upgradeprovision-oldrelease.sh, but not this file.  Why
> > doesn't this fail for everyone?
> 
> asn at magrathea:~/workspace/projects/samba/git> git bisect bad
> Bisecting: 0 revisions left to test after this (roughly 0 steps)
> [b9701a0a79dd15dd6f53075638fba9a2a3d92e19] provision: Change the default 
> functional level of new Samba domains to 2008R2.
> 
> Yes, this is the culprit :)
> 
> 
> The attached patch fixes the issue for me. The question is why doesn't it work 
> if the functional level is 2008r2?

Quite simply because that LDAP attribute represents the functional
level, and the 4.0.0 provision was made with 2003, so we have to try and
match that in the new provision before we compare. 

I'm still quite worried that autobuild let this past.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba