Latest leases patchset - getting there !
jra at samba.org
Fri Dec 5 09:38:50 MST 2014
On Fri, Dec 05, 2014 at 02:45:38PM +0100, Stefan (metze) Metzmacher wrote:
> Am 05.12.2014 um 09:43 schrieb Stefan (metze) Metzmacher:
> > Hi Jeremy,
> >> New turbo enhanced version :-).
> >> With leases you can have multiple RH
> >> lease handles, and if one of them renames
> >> the file you must break to a R lease,
> >> *and wait for the client response before
> >> doing the rename*.
> >> This means that I had to make SMB2 setinfo
> >> async for the SMB2_FILE_RENAME_INFORMATION_INTERNAL
> >> call.
> >> Full patch that goes on top of master attached,
> >> includes enhanced smb2.lease.v2_rename test
> >> that shows the above behavior (we pass it :-).
> >> Please review and push (or comment :-).
> > Thanks for the patches!
> > There're one thing which needs be fixed...
> > defer_rename_done needs to call
> > change_to_user(req->tcon->compat, req->session->compat->vuid)
> > and
> > set_current_server(req->tcon->compat, 0, true)
> > similar to smbd_smb2_request_check_tcon().
> Ok, here's an updated patchset that implements this
> and also verifies that we can open with the lease after the 2nd rename.
Thanks ! Pushed to master.
More information about the samba-technical