[PATCH] Change libpdb -> libsamba-passdb, break ABI and fix Bug 10720 - error: Unable to convert first SID
jelmer at samba.org
Mon Dec 1 05:52:58 MST 2014
On Mon, Dec 01, 2014 at 11:47:52AM +1300, Andrew Bartlett wrote:
> Just a heads-up with a broader subject line to gain some more attention.
> This fix is a blocker for 4.2, but we didn't want to put it in without
> giving the rest of the team a reasonable chance to comment. If you have
> concerns after reading over this, please let us know soon!
Looks good to me.
A rename like this is going to be painful anyhow. Let's just bite the bullet and
get it over with.
'libsamba-passdb' seems like a good name; unlikely to conflict with anything else,
> On Fri, 2014-11-28 at 15:35 +1300, Garming Sam wrote:
> > On 26/11/14 16:11, Garming Sam wrote:
> > > The first two patches improves our current testing to correctly
> > > identify the error. They simply build upon the existing wbinfo_sid2xid
> > > tests and are currently in auto-build.
> > >
> > > The other three patches fix the actual issue. The first plumbs a
> > > pointer to struct unixid instead of uid/gid. The second fixes the
> > > return of the id type and the last fixes the ABI - which with
> > > renaming, we can also fix another bug
> > > (https://bugzilla.samba.org/show_bug.cgi?id=10355) where it has naming
> > > conflicts with Brookhaven Protein DataBank libpdb.
> > >
> > The first two patches are now in master, with a minor change to flush
> > the cache for the other tests.
> > The other three only appear to have failed the duplicate symbol check so
> > I've reattached the patches with the build scripts slightly modified so
> > they don't depend on pdb directly.
> > Thoughts would be nice.
> > Thanks,
> > Garming Sam
> Andrew Bartlett
> Authentication Developer, Samba Team http://samba.org
> Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical