[PATCH 5/5] samba.netcmd.domain: Fix python formatting; no unnecessary parentheses, break long line.

David Disseldorp ddiss at suse.de
Sun Aug 31 11:39:36 MDT 2014

Hi Jelmer,

These cleanups all look good. I've pushed everything aside from this
patch, which is missing a sign-off:

source4: Remove script to find unused makefile variables.
find_unused_macros: Remove obsolete script that finds unused macros.
Remove mention of compatibility with Python 2.4.
replace: remove unused and duplicate imports.
replace: remove tabs. 
Look for system setproctitle before trying -lbsd.
samba.netcmd.domain: Just catch ImportError, not any parsing errors in cmd_domain_export_keytab.
samba.netcmd.domain: Remove unused import.
samba.netcmd.domain: Fix incorrect variable names, causing NameErrors.
samba.netcmd.domain: desactivating -> deactivating.
Remove trailing whitespace.
Various updates to the pidl README file.

Feel free to push this one with my Reviewed-by tag, once you add a sign

Cheers, David

More information about the samba-technical mailing list