[PATCH 0/6] various FSCTL_SET_SPARSE tests and a bug fix
jra at samba.org
Thu Aug 28 21:28:57 MDT 2014
On Thu, Aug 28, 2014 at 06:26:53PM -0700, Jeremy Allison wrote:
> On Thu, Aug 28, 2014 at 11:27:22AM -0700, Jeremy Allison wrote:
> > On Wed, Aug 27, 2014 at 03:41:56PM +0200, David Disseldorp wrote:
> > > This patch-set adds a number of tests for FSCTL_SET_SPARSE to:
> > > - Check that the sparse attribute is retained / cleared according to
> > > MS-FSCC specs, with and without a SetSparse buffer.
> > > - Confirm that the FSCTL fails with STATUS_INVALID_PARAMETER when
> > > requested with a directory handle.
> > > - This was broken on Samba (bso#10787). A fix is included.
> > >
> > > The added tests are currently skipped against (unmodified) Samba, as it
> > > doesn't advertise the FILE_SUPPORTS_SPARSE_FILES capability flag.
> > >
> > > Feedback appreciated.
> > LGTM - pushed. Thanks !
> Grrr. Hasn't gone through yet. Having autobuild issues.
> I'll try again...
Ah - this is why the autobuild is failing.
[1222/1680 in 1h19m29s] samba4.smb2.ioctl(dc)
REASON: _StringException: _StringException: ../source4/torture/smb2/ioctl.c:2563: status was NT_STATUS_INVALID_DEVICE_REQUEST, expected NT_STATUS_OK: FSCTL_SET_SPARSE
David, you need to set samba4.smb2.ioctl.sparse_file_flag
as a knownfail. Patch for this is attached. If
you're happy feel free to re-push your code
with my 'Reviewed-by' and this extra patch
IMHO it's time to delete the samba4 NTFS server
code as it's causing more errors in builds than
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 858 bytes
Desc: not available
More information about the samba-technical