[PATCH 0/6] various FSCTL_SET_SPARSE tests and a bug fix

Jeremy Allison jra at samba.org
Thu Aug 28 19:26:53 MDT 2014


On Thu, Aug 28, 2014 at 11:27:22AM -0700, Jeremy Allison wrote:
> On Wed, Aug 27, 2014 at 03:41:56PM +0200, David Disseldorp wrote:
> > This patch-set adds a number of tests for FSCTL_SET_SPARSE to:
> > - Check that the sparse attribute is retained / cleared according to
> >   MS-FSCC specs, with and without a SetSparse buffer.
> > - Confirm that the FSCTL fails with STATUS_INVALID_PARAMETER when
> >   requested with a directory handle.
> > 	- This was broken on Samba (bso#10787). A fix is included.
> > 
> > The added tests are currently skipped against (unmodified) Samba, as it
> > doesn't advertise the FILE_SUPPORTS_SPARSE_FILES capability flag.
> > 
> > Feedback appreciated.
> 
> LGTM - pushed. Thanks !

Grrr. Hasn't gone through yet. Having autobuild issues.

I'll try again...



More information about the samba-technical mailing list