[PATCH v2 2/3] common: add cifs support

Pavel Shilovsky piastryyy at gmail.com
Thu Aug 28 13:08:39 MDT 2014


>> 28 авг. 2014 г., в 21:18, Christoph Hellwig <hch at infradead.org> написал(а):
>> 
>> On Wed, Aug 27, 2014 at 12:28:37AM +0400, Pavel Shilovsky wrote:
>> +    - You can explicitly specify NFS or CIFS, otherwise the filesystem type will
>> +      be autodetected from $TEST_DEV:
>>      ./check -nfs [test(s)]
> 
> Can you take care of mentioning tmpfs as well, looks like it didn't get
> added here when support was added.

Ok, will add it.

> 
>>   ;;
>> +    cifs)
>> +    # Don't know how to check a CIFS filesystem, yet.
>> +    ;;
> 
> Will we ever find a way to sanity check a cifs fs? :)
> 
> Otherwise looks fine to me.

Probably some day we will be able to run fsck checks on the remote server through a specific rpc.

Thank you for the review - will repost the series.

--
Best regards,
Pavel Shilovsky.



More information about the samba-technical mailing list