[PATCH] vfs module for VxFS
Abhidnya_Joshi at symantec.com
Thu Aug 28 02:00:14 MDT 2014
Thanks for the quick review.
Please find attached patch with changes.
Thanks and Regards
From: Jeremy Allison [mailto:jra at samba.org]
Sent: Thursday, August 28, 2014 4:58 AM
To: Abhidnya Joshi
Cc: samba-technical at samba.org
Subject: Re: [PATCH] vfs module for VxFS
On Wed, Aug 27, 2014 at 05:32:49AM -0700, Abhidnya Joshi wrote:
> Hi List,
> As part of our NAS product, we are using Samba on top of Symantec File System (VxFS).
> We are making use of acl_xattr module to interpret and store NTACLs.
> This module tries to fix 2 issues:
> 1. Presently VxFS does not support security namespace for named attrs thus, NTACLs have to be stored under user.NTACL.
> 2. In VxFS, typically newly created file will share POSIX ACLs of its parent unless explicit ACL set call is made. POSIX ACLs are stored as an extended attr of a file/dir which uses separate inode.
> That means if there is sharing of ACLs, lesser number of Inodes. With acl_xattr, it is always explicit set ACL call after file/dir create. Thus inode number doubles!
> Our idea here is, do not set ACLs if existing POSIX ACLs are same with whatever Samba calculated as far as possible.
> Please find attached patch which adds new module for VxFS which can handle this.
> This patch applies to Samba master. Please let me know reviews/comments.
Thanks Abhidnya, I'll do a full review of this shortly.
One thing I know I'm going to ask for though, is to fix the printf format strings :-).
I noticed you're doing things like :
"Format string %d", val
where val is defined as uint32_t, or uint16_t.
These will cause compiler warnings on most modern gcc systems.
The format should be "%u" for printing unsigned types, and remember to cast the value to (unsigned) to match the format type.
More as I have time to review, but you might get ahead of the curve by fixing these first and sending another round :-).
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 17552 bytes
More information about the samba-technical